Re: [PATCH v1 2/5] char: tpm: Add check_data handle to tpm_tis_phy_ops in order to check data integrity

[Jarkko Sakkinen]

On Sun, Nov 10, 2019 at 06:21:34PM +0200, amirmizi6@xxxxxxxxx wrote:
> From: Amir Mizinski <amirmizi6@xxxxxxxxx>
> 
> The current principles:
> - When sending command:
> 1. Host writes TPM_STS.commandReady
> 2. Host writes command
> 3. Host checks TPM received data correctly
> 4. if not go to step 1

You are probably talking about steps, right?

Please check the grammar and punctation e.g. "The current steps are
roughly done when sending a command".

> - When receiving data:
> 1. Host check TPM_STS.dataAvail is set
> 2. Host get data
> 3. Host check received data are correct.
> 4. if not Host write TPM_STS.responseRetry and go to step 1.
> 
> this commit is based on previous work by Christophe Richard

Sentences in English start with a capital letter and end with a full
stop.

This is completely lacking the description what the commit does.

/Jarkko