Re: [PATCH net-next] ptp: ptp_clockmatrix: Fix build error

From: Vincent Cheng
Date: Tue Nov 12 2019 - 09:48:03 EST


On Tue, Nov 12, 2019 at 09:35:14AM EST, YueHaibing wrote:
>When do randbuilding, we got this warning:
>
>WARNING: unmet direct dependencies detected for PTP_1588_CLOCK
> Depends on [n]: NET [=y] && POSIX_TIMERS [=n]
> Selected by [y]:
> - PTP_1588_CLOCK_IDTCM [=y]
>
>Make PTP_1588_CLOCK_IDTCM depends on PTP_1588_CLOCK to fix this.
>
>Fixes: 3a6ba7dc7799 ("ptp: Add a ptp clock driver for IDT ClockMatrix.")
>Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
>---
> drivers/ptp/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
>index c48ad23..b45d2b8 100644
>--- a/drivers/ptp/Kconfig
>+++ b/drivers/ptp/Kconfig
>@@ -121,7 +121,7 @@ config PTP_1588_CLOCK_KVM
>
> config PTP_1588_CLOCK_IDTCM
> tristate "IDT CLOCKMATRIX as PTP clock"
>- select PTP_1588_CLOCK
>+ depends on PTP_1588_CLOCK
> default n
> help
> This driver adds support for using IDT CLOCKMATRIX(TM) as a PTP
>--

Oops. Thank-you for the fix.

Reviewed-by: Vincent Cheng <vincent.cheng.xh@xxxxxxxxxxx>