Re: [PATCH 04/16] libnvdimm: Move nd_numa_attribute_group to device_type

From: Aneesh Kumar K.V
Date: Tue Nov 12 2019 - 04:24:29 EST


Dan Williams <dan.j.williams@xxxxxxxxx> writes:

> A 'struct device_type' instance can carry default attributes for the
> device. Use this facility to remove the export of
> nd_numa_attribute_group and put the responsibility on the core rather
> than leaf implementations to define this attribute.
>
> Cc: Ira Weiny <ira.weiny@xxxxxxxxx>
> Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> Cc: "Oliver O'Halloran" <oohall@xxxxxxxxx>
> Cc: Vishal Verma <vishal.l.verma@xxxxxxxxx>
> Cc: Aneesh Kumar K.V <aneesh.kumar@xxxxxxxxxxxxx>
> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>


can we also expose target_node in a similar way? This allows application
to better understand the node locality of the SCM device.

-aneesh