RE: [PATCH] RISC-V: Add address map dumper

From: Yash Shah
Date: Tue Nov 12 2019 - 01:35:59 EST


> -----Original Message-----
> From: Mike Rapoport <rppt@xxxxxxxxxxxxx>
> Sent: 12 November 2019 03:27
> To: Yash Shah <yash.shah@xxxxxxxxxx>
> Cc: Paul Walmsley ( Sifive) <paul.walmsley@xxxxxxxxxx>; linux-
> riscv@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> palmer@xxxxxxxxxxx; aou@xxxxxxxxxxxxxxxxx; Anup.Patel@xxxxxxx;
> logang@xxxxxxxxxxxx; ren_guo@xxxxxxxxx; bmeng.cn@xxxxxxxxx;
> tglx@xxxxxxxxxxxxx; Sachin Ghadi <sachin.ghadi@xxxxxxxxxx>
> Subject: Re: [PATCH] RISC-V: Add address map dumper
>
> Hi,
>
> On Mon, Nov 11, 2019 at 05:27:25AM +0000, Yash Shah wrote:
> > Add support for dumping the kernel address space layout to the console.
> > User can enable CONFIG_DEBUG_VM_LAYOUT to dump the virtual
> memory
> > region into dmesg buffer during boot-up.
> >
> > Signed-off-by: Yash Shah <yash.shah@xxxxxxxxxx>
> > ---
> > This patch is based on Linux 5.4-rc6 and tested on SiFive HiFive
> > Unleashed board.
> > ---
> > arch/riscv/Kconfig.debug | 9 +++++++++
> > arch/riscv/mm/init.c | 30 ++++++++++++++++++++++++++++++
> > 2 files changed, 39 insertions(+)
> >
> > diff --git a/arch/riscv/Kconfig.debug b/arch/riscv/Kconfig.debug index
> > e69de29..cdedfd3 100644
> > --- a/arch/riscv/Kconfig.debug
> > +++ b/arch/riscv/Kconfig.debug
> > @@ -0,0 +1,9 @@
> > +config DEBUG_VM_LAYOUT
>
> I believe this could be enabled when CONFIG_DEBUG_VM=y without adding
> yet another architecture specific Kconfig option.

Oh yes, I will drop the newly added kconfig option in v2.

> --
> Sincerely yours,
> Mike.

Thanks for your comment!

- Yash