Re: [PATCH] net: mdio-octeon: Fix pointer/integer casts

From: David Miller
Date: Tue Nov 12 2019 - 00:47:08 EST


From: Olof Johansson <olof@xxxxxxxxx>
Date: Sun, 10 Nov 2019 16:42:11 -0800

> -static inline void oct_mdio_writeq(u64 val, u64 addr)
> +static inline void oct_mdio_writeq(u64 val, void __iomem *addr)
> {
> - cvmx_write_csr(addr, val);
> + cvmx_write_csr((u64)addr, val);
> }

I hate stuff like this, I think you really need to fix this from the bottom
up or similar. MMIO and such addresses are __iomem pointers, period.