Re: [PATCH][next] xen/gntdev: remove redundant non-zero check on ret

[JÃrgen GroÃ]

On 11.11.19 13:31, Colin Ian King wrote:
> On 11/11/2019 12:25, JÃrgen Groà wrote:
> > On 11.11.19 13:20, Colin King wrote:
> > > From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> > >
> > > The non-zero check on ret is always going to be false because
> > > ret was initialized as zero and the only place it is set to
> > > non-zero contains a return path before the non-zero check. Hence
> > > the check is redundant and can be removed.
> >
> > Which version did you patch against? In current master the above
> > statement is not true.
>
> against today's linux-next

Ah, okay, this is likely the result of the recent mm-notifier patch
series. I'll put this patch on hold until the recent patches have
hit master.


Juergen