Re: [PATCH] irqchip/ti-sci-inta: Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...))

[Marc Zyngier]

On 2019-11-11 04:45, Lokesh Vutla wrote:
> On 05/11/19 5:00 PM, Markus Elfring wrote:
> > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> > Date: Tue, 5 Nov 2019 12:19:39 +0100
> >
> > A coccicheck run provided information like the following.
> >
> > drivers/irqchip/irq-ti-sci-inta.c:250:9-16: WARNING: ERR_CAST can be 
> > used
> > with vint_desc.
> >
> > Generated by: scripts/coccinelle/api/err_cast.cocci
> >
> > Thus adjust the exception handling in one if branch.
> >
> > Fixes: 9f1463b86c13277d0bd88d5ee359577ef40f4da7 
> > ("irqchip/ti-sci-inta: Add support for Interrupt Aggregator driver")
>
> Fixes: 9f1463b86c13 ("irqchip/ti-sci-inta: Add support for Interrupt 
> Aggregator driver")

I fundamentally disagree with the "Fixes:" tag. This isn't a fix,
just a minor readability improvement. Flagging things as "Fixes:"
ends up triggering all kind of unnecessary backports to -stable.

> With this:
>
> Reviewed-by: Lokesh Vutla <lokeshvutla@xxxxxx>

I'll otherwise take this patch in -next.

Thanks,

        M.
--
Jazz is not dead. It just smells funny...