Re: [PATCH 38/46] video: backlight: tosa: use gpio lookup table

From: Lee Jones
Date: Mon Nov 11 2019 - 04:30:52 EST


On Fri, 18 Oct 2019, Arnd Bergmann wrote:

> The driver should not require a machine specific header. Change
> it to pass the gpio line through a lookup table, and move the
> timing generator definitions into the drivers itself.
>
> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> Cc: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
> Cc: Jingoo Han <jingoohan1@xxxxxxxxx>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Cc: linux-fbdev@xxxxxxxxxxxxxxx
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> ---
> I'm not overly confident that I got the correct device names
> for the lookup table, it would be good if someone could
> double-check.
> ---
> arch/arm/mach-pxa/include/mach/tosa.h | 15 --------------
> arch/arm/mach-pxa/tosa.c | 22 +++++++++++++++++++++
> drivers/video/backlight/tosa_bl.c | 10 +++++-----
> drivers/video/backlight/tosa_bl.h | 8 ++++++++
> drivers/video/backlight/tosa_lcd.c | 28 ++++++++++++++++++++-------
> 5 files changed, 56 insertions(+), 27 deletions(-)
> create mode 100644 drivers/video/backlight/tosa_bl.h

Applied, thanks.

--
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog