Re: [v3] s390/pkey: Use memdup_user() rather than duplicating its implementation

From: Markus Elfring
Date: Mon Nov 11 2019 - 03:11:30 EST


>> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
>> Date: Fri, 8 Nov 2019 17:50:22 +0100
â
>> Fixes: f2bbc96e7cfad3891b7bf9bd3e566b9b7ab4553d ("s390/pkey: add CCA AES cipher key support")
>> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
>
> You were sending this from a different email address.

Yes.


> Can you use the same for the sender and the signoff?

I would prefer to use the other email address (for a while).


> Can you also change the subject to indicate the "fix". e.g. something like
>
> s390/pkey: fix memory leak in error case by using memdup_user() rather than open coding

Does this change request indicate also a need to split the software update
between the discussed two function implementations?

Regards,
Markus