Re: [PATCH] phy: allwinner: Fix GENMASK misuse

[OndÅej Jirman]

On Fri, Nov 08, 2019 at 12:41:39PM +0100, megous hlavni wrote:
> On Fri, Nov 08, 2019 at 07:29:21PM +0800, Icenowy Zheng wrote:
> > 
> > 
> > ä 2019å11æ8æ GMT+08:00 äå5:45:14, "OndÅej Jirman" <megous@xxxxxxxxxx> åå:
> > >Hello Rikard,
> > >
> > >On Thu, Nov 07, 2019 at 09:46:45PM +0100, Rikard Falkeborn wrote:
> > >> Arguments are supposed to be ordered high then low.
> > >> 
> > >> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@xxxxxxxxx>
> > >> ---
> > >> Spotted while trying to add compile time checks of GENMASK arguments.
> > >> Patch has only been compile tested.
> > >
> > >thank you!
> > >
> > >Tested-by: Ondrej Jirman <megous@xxxxxxxxxx>
> > 
> > Does it affect or fix the performance?
> 
> See here: https://forum.armbian.com/topic/10131-orange-pi-lite2-usb3-now-working/?do=findComment&comment=88904
> 
> Quote:
> 
> > It may or may not help. On Opi3 I see no change, probably because HUB is
> > really close to the SoC, but on boards without a HUB, SoC's USB3 phy will
> > have to drive the signal over the longer cable and this patch might benefit
> > those boards. 
> 
> Maybe someone with boards without PHY will test it more.

Eh, on boards without a USB3 HUB.

> regards,
> 	o.
> 
> > >
> > >regards,
> > >	o.
> > >
> > >>  drivers/phy/allwinner/phy-sun50i-usb3.c | 2 +-
> > >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > >> 
> > >> diff --git a/drivers/phy/allwinner/phy-sun50i-usb3.c
> > >b/drivers/phy/allwinner/phy-sun50i-usb3.c
> > >> index 1169f3e83a6f..b1c04f71a31d 100644
> > >> --- a/drivers/phy/allwinner/phy-sun50i-usb3.c
> > >> +++ b/drivers/phy/allwinner/phy-sun50i-usb3.c
> > >> @@ -49,7 +49,7 @@
> > >>  #define SUNXI_LOS_BIAS(n)		((n) << 3)
> > >>  #define SUNXI_LOS_BIAS_MASK		GENMASK(5, 3)
> > >>  #define SUNXI_TXVBOOSTLVL(n)		((n) << 0)
> > >> -#define SUNXI_TXVBOOSTLVL_MASK		GENMASK(0, 2)
> > >> +#define SUNXI_TXVBOOSTLVL_MASK		GENMASK(2, 0)
> > >>  
> > >>  struct sun50i_usb3_phy {
> > >>  	struct phy *phy;
> > >> -- 
> > >> 2.24.0
> > >>