Re: [PATCH v5 06/13] drivers: irqchip: qcom-pdc: Move to an SoC independent compatible

From: Rajendra Nayak
Date: Fri Nov 08 2019 - 04:56:05 EST



On 11/8/2019 3:10 PM, Marc Zyngier wrote:
On 2019-11-08 10:37, Rajendra Nayak wrote:
Remove the sdm845 SoC specific compatible to make the driver
easily reusable across other SoC's with the same IP block.
This will reduce further churn adding any SoC specific
compatibles unless really needed.

Signed-off-by: Rajendra Nayak <rnayak@xxxxxxxxxxxxxx>
Reviewed-by: Lina Iyer <ilina@xxxxxxxxxxxxxx>
Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
Cc: Marc Zyngier <maz@xxxxxxxxxx>
---
Âdrivers/irqchip/qcom-pdc.c | 2 +-
Â1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c
index faa7d61b9d6c..c175333bb646 100644
--- a/drivers/irqchip/qcom-pdc.c
+++ b/drivers/irqchip/qcom-pdc.c
@@ -309,4 +309,4 @@ static int qcom_pdc_init(struct device_node
*node, struct device_node *parent)
ÂÂÂÂ return ret;
Â}

-IRQCHIP_DECLARE(pdc_sdm845, "qcom,sdm845-pdc", qcom_pdc_init);
+IRQCHIP_DECLARE(qcom_pdc, "qcom,pdc", qcom_pdc_init);

Acked-by: Marc Zyngier <marc.zyngier@xxxxxxx>

How do you want me get this (and the DT change) merged? I can either take
these two patches in the irqchip tree, or you arrange them to be taken
by the platform maintainers. Your call.

I think it makes sense for you to take these two via your tree (The driver
and binding doc updates) and the DT node addition for pdc to go via Andy/Bjorn.
Andy/Bjorn, does that sound fine?

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation