Re: [RFC PATCH 01/12] i2c: replace i2c_new_probed_device with an ERR_PTR variant

From: Wolfram Sang
Date: Thu Nov 07 2019 - 14:22:42 EST


Hi Luca,

> I beg your pardon for the newbie question, perhaps a stupid one, kind of
> nitpicking, and not even strictly related to this patch, but what's the
> reason for these functions being declared extern?

I did this for consistency reasons. I agree that the 'extern' keyword
could need some second thought, yet I think that should be a seperate
patchset. And that does not have priority for me, so if someone is
interested... :)

> For the rest LGTM, I did some grep checks before/after the patchset, ran
> some build tests, and everything looks fine.

Cool, thanks for your review!

All the best,

Wolfram

Attachment: signature.asc
Description: PGP signature