Re: [PATCH 2/2] rtc: bd70528: Fix hour register mask

From: Alexandre Belloni
Date: Thu Nov 07 2019 - 06:33:56 EST


On 07/11/2019 10:59:49+0000, Lee Jones wrote:
> On Tue, 05 Nov 2019, Alexandre Belloni wrote:
>
> > On 23/10/2019 14:47:51+0300, Matti Vaittinen wrote:
> > > When RTC is used in 24H mode (and it is by this driver) the maximum
> > > hour value is 24 in BCD. This occupies bits [5:0] - which means
> > > correct mask for HOUR register is 0x3f not 0x1f. Fix the mask
> > >
> > > Fixes: 32a4a4ebf768 ("rtc: bd70528: Initial support for ROHM bd70528 RTC")
> > > Signed-off-by: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx>
> > > ---
> > > include/linux/mfd/rohm-bd70528.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > Applied, thanks.
>
> You have been duped. This is clearly not an RTC patch.
>

Well, it only affects the RTC driver. Do you want to take it?

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com