Re: [PATCH untested] x86_32: fix extable entry for iret

From: Andy Lutomirski
Date: Wed Nov 06 2019 - 23:54:40 EST


On Wed, Nov 6, 2019 at 8:41 PM Lai Jiangshan <laijs@xxxxxxxxxxxxxxxxx> wrote:
>
> 3c88c692c287(x86/stackframe/32: Provide consistent pt_regs)
> added code after label .Lirq_return and before 'iret', an instruction
> which should be expected to be found in the extable when there is
> an exception on it. But the extable entry stores the address of
> .Lirq_return not the new address of 'iret', which disables
> the corresponding fixup. This patch fixes the extable entry
> by using a new label.

Egads!

What happens if you run tools/testing/selftests/x86/sigreturn_32 with
and without this patch?

--Andy