Re: [PATCH v2] fscrypt: avoid data race on fscrypt_mode::logged_impl_name

From: Eric Biggers
Date: Wed Nov 06 2019 - 16:02:09 EST


On Mon, Oct 21, 2019 at 01:49:03PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@xxxxxxxxxx>
>
> The access to logged_impl_name is technically a data race, which tools
> like KCSAN could complain about in the future. See:
> https://github.com/google/ktsan/wiki/READ_ONCE-and-WRITE_ONCE
>
> Fix by using xchg(), which also ensures that only one thread does the
> logging.
>
> This also required switching from bool to int, to avoid a build error on
> the RISC-V architecture which doesn't implement xchg on bytes.
>
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>

Applied to fscrypt.git#master for 5.5.

- Eric