Re: [PATCH][next] xfs: remove redundant assignment to variable error

[Eric Sandeen]

On 11/6/19 9:59 AM, Colin Ian King wrote:
> On 06/11/2019 15:56, Darrick J. Wong wrote:
>> On Wed, Nov 06, 2019 at 03:52:48PM +0000, Colin King wrote:
>>> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>>>
>>> Variable error is being initialized with a value that is never read
>>> and is being re-assigned a couple of statements later on. The
>>> assignment is redundant and hence can be removed.
>>>
>>> Addresses-Coverity: ("Unused value")
>>
>> Er... is there a coverity id that goes with this?
> 
> Unfortunately it is a private one, so it does not make sense to use it.

If it's not in the upstream coverity scan (and AFAICT it's not),
it makes no sense to reference coverity in the commit log.
It's not useful to anyone IMHO.

-Eric