Re: [Patch v2 12/20] media: ti-vpe: cal: Add DRA76x support

From: Sakari Ailus
Date: Wed Nov 06 2019 - 03:58:28 EST


Hi Benoit,

On Mon, Nov 04, 2019 at 01:31:32PM -0600, Benoit Parrot wrote:

...

> +static struct cal_data dra76x_cal_data = {

const?

> + .csi2_phy_core = dra76x_cal_csi_phy,
> + .num_csi2_phy = ARRAY_SIZE(dra76x_cal_csi_phy),
> +

This newline seems extra.

> + .flags = 0,

And flags will be zero in any case, as one more struct members are assigned
to.

> +};

--
Regards,

Sakari Ailus