Re: spdxcheck.py complains about the second OR?

From: Christoph Hellwig
Date: Tue Nov 05 2019 - 10:48:01 EST


On Mon, Nov 04, 2019 at 02:24:23PM -0800, Joe Perches wrote:
> On Mon, 2019-11-04 at 23:11 +0100, Thomas Gleixner wrote:
> > On Fri, 1 Nov 2019, Masahiro Yamada wrote:
> > > scripts/spdxcheck.py warns the following two files.
> > >
> > > $ ./scripts/spdxcheck.py
> > > drivers/net/ethernet/pensando/ionic/ionic_if.h: 1:52 Syntax error: OR
> > > drivers/net/ethernet/pensando/ionic/ionic_regs.h: 1:52 Syntax error: OR
> > >
> > > I do not understand what is wrong with them.
> > >
> > > I think "A OR B OR C" is sane.
> >
> > Yes it is, but obviously we did not expect files with 3 possible
> > alternative licenses.
>
> Perhaps just this, but the generic logic
> obviously isn't complete.

Can we please print a warning in that case even if we end up parsing
it correct? tripple licensing always has a bit of a bad smell.