Re: [PATCH 10/14] soundwire: intel: add prepare support in sdw dai driver

[Pierre-Louis Bossart]

On 11/4/19 1:45 PM, Cezary Rojewski wrote:
> On 2019-10-23 23:28, Pierre-Louis Bossart wrote:
> > From: Rander Wang <rander.wang@xxxxxxxxxxxxxxx>
> >
> > It gets sdw runtime information from dai to prepare stream.
> >
> > Signed-off-by: Rander Wang <rander.wang@xxxxxxxxxxxxxxx>
> > Signed-off-by: Pierre-Louis Bossart 
> > <pierre-louis.bossart@xxxxxxxxxxxxxxx>
>
> While the patch looks good, the commit message is questionable. You may 
> simply state why it is added only just now. Judging from the commit 
> title, it has been added to make the sdw dai driver interface complete.

The commit message is not great but it's not wrong either...