Re: [PATCH v2] staging: comedi: rewrite macro function with GNU extension typeof

From: Greg KH
Date: Mon Nov 04 2019 - 11:46:58 EST


On Mon, Nov 04, 2019 at 04:33:31PM +0000, Jules Irenge wrote:
> Rewrite macro function with the GNU extension typeof
> to remove a possible side-effects of MACRO argument reuse "x".
> - Problem could rise if arguments have different types
> and different use though.

You can not just get away with a potential problem by documenting it :)

You might have just broken this. Why are you trying to "fix" something
that is not broken?

What is wrong with the code as-is?

thanks,

greg k-h