Re: [PATCH v6] coccicheck: Support search for SmPL scripts within selected directory hierarchy

From: Markus Elfring
Date: Mon Nov 04 2019 - 10:41:10 EST


> *Allow defining the environment variable âCOCCIâ as a directory to
> search SmPL scripts.
>
> *Start a corresponding file determination if it contains an acceptable
> path.
>
> *Update coccinelle.rst documents for use coccicheck with a directory
> selection

â Do you really insist to use an enumeration without alignment
in your change description?

â Can the following third item be nicer?

* Adjust software documentation for using coccicheck with
a selected directory.


> +++ b/Documentation/dev-tools/coccinelle.rst
> @@ -100,8 +100,8 @@ Two other modes provide some common combinations of these modes.
â
> +Using Coccinelle with defalut value

Why did you repeat a typo?

How do you think about to use the section title âUsing Coccinelle
with the default configurationâ?


â
> +semantic patch. In that case, the variable must be initialized with
> +the name of the semantic patch to apply.

I prefer an other wording.

â, it should be set to the file name of the semantic patch to apply.


â
> +directory. In that case, the variable must be initialized with the name of

â, it should be set to the â


Will the presented case distinction need another adjustment
for the document outline?


â
> Controlling Which Files are Processed by Coccinelle
â

Did you overlook another update candidate (which I tried to point out before)?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/dev-tools/coccinelle.rst?id=a99d8080aaf358d5d23581244e5da23b35e340b9#n189
ââ
COCCI variable may additionally be used to only apply a single
semantic patch as shown in the previous section.
ââ


Regards,
Markus