Re: [PATCH v5 7/7] perf report: Sort by sampled cycles percent per block for tui

[Jin, Yao]

On 11/1/2019 4:34 PM, Jiri Olsa wrote:
> On Wed, Oct 30, 2019 at 02:04:30PM +0800, Jin Yao wrote:
>
> SNIP
>
> > diff --git a/tools/perf/ui/browsers/hists.h b/tools/perf/ui/browsers/hists.h
> > index 91d3e18b50aa..078f2f2c7abd 100644
> > --- a/tools/perf/ui/browsers/hists.h
> > +++ b/tools/perf/ui/browsers/hists.h
> > @@ -5,6 +5,7 @@
> >   #include "ui/browser.h"
> >   
> >   struct annotation_options;
> > +struct evsel;
> >   
> >   struct hist_browser {
> >   	struct ui_browser   b;
> > @@ -15,6 +16,7 @@ struct hist_browser {
> >   	struct pstack	    *pstack;
> >   	struct perf_env	    *env;
> >   	struct annotation_options *annotation_opts;
> > +	struct evsel	    *block_evsel;
>
> you should be able to get the evsel from hists_to_evsel function
>
> jirka

Maybe we can't. The hists in hist_browser is set to block_hists (not the 
hists for evsel).

See block_hists_tui_browse,

int block_hists_tui_browse(struct block_hist *bh, struct evsel *evsel,
                          float min_percent)
{
       struct hists *hists = &bh->block_hists;
       struct hist_browser *browser;
       ......
       browser = hist_browser__new(hists);
       ......
}

So I have to pass the evsel in.

Thanks
Jin Yao