Re: [RFC 02/10] autonuma: Reduce cache footprint when scanning page tables

From: Mel Gorman
Date: Fri Nov 01 2019 - 07:13:13 EST


On Fri, Nov 01, 2019 at 03:57:19PM +0800, Huang, Ying wrote:
> From: Huang Ying <ying.huang@xxxxxxxxx>
>
> In auto NUMA balancing page table scanning, if the pte_protnone() is
> true, the PTE needs not to be changed because it's in target state
> already. So other checking on corresponding struct page is
> unnecessary too.
>
> So, if we check pte_protnone() firstly for each PTE, we can avoid
> unnecessary struct page accessing, so that reduce the cache footprint
> of NUMA balancing page table scanning.
>
> In the performance test of pmbench memory accessing benchmark with
> 80:20 read/write ratio and normal access address distribution on a 2
> socket Intel server with Optance DC Persistent Memory, perf profiling
> shows that the autonuma page table scanning time reduces from 1.23% to
> 0.97% (that is, reduced 21%) with the patch.
>
> Signed-off-by: "Huang, Ying" <ying.huang@xxxxxxxxx>

Acked-by: Mel Gorman <mgorman@xxxxxxx>

This patch is independent of the series and should be resent separately.
Alternatively Andrew, please pick this patch up on its own.

--
Mel Gorman
SUSE Labs