Re: [PATCH] fsnotify: Use NULL instead of 0 for pointer

[Jan Kara]

On Wed 30-10-19 21:12:37, Tiezhu Yang wrote:
> On 10/30/2019 08:21 PM, Jan Kara wrote:
> > On Tue 29-10-19 21:39:02, Tiezhu Yang wrote:
> > > Fix the following sparse warning:
> > > 
> > > fs/notify/fdinfo.c:53:87: warning: Using plain integer as NULL pointer
> > > 
> > > Fixes: be77196b809c ("fs, notify: add procfs fdinfo helper")
> > > Signed-off-by: Tiezhu Yang <yangtiezhu@xxxxxxxxxxx>
> > Thanks for the patch but similar patch already sits in my tree as commit
> > ddd06c36bdb "fsnotify/fdinfo: exportfs_encode_inode_fh() takes pointer as
> > 4th argument". I'll send it to Linus in the next merge window.
> > 
> > 								Honza
> 
> Thanks for your reply. I can not find your tree about fs/notify
> in the MAINTAINERS file, so this patch is based on Linus's tree.
> Sorry for the noise, you can ignore it.
> 
> By the way, could you add your tree in the MAINTAINERS file?

Good idea! Added. Thanks!

								Honza

> > > ---
> > >   fs/notify/fdinfo.c | 3 ++-
> > >   1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/fs/notify/fdinfo.c b/fs/notify/fdinfo.c
> > > index 1e2bfd2..cd2846e 100644
> > > --- a/fs/notify/fdinfo.c
> > > +++ b/fs/notify/fdinfo.c
> > > @@ -50,7 +50,8 @@ static void show_mark_fhandle(struct seq_file *m, struct inode *inode)
> > >   	f.handle.handle_bytes = sizeof(f.pad);
> > >   	size = f.handle.handle_bytes >> 2;
> > > -	ret = exportfs_encode_inode_fh(inode, (struct fid *)f.handle.f_handle, &size, 0);
> > > +	ret = exportfs_encode_inode_fh(inode, (struct fid *)f.handle.f_handle,
> > > +				       &size, NULL);
> > >   	if ((ret == FILEID_INVALID) || (ret < 0)) {
> > >   		WARN_ONCE(1, "Can't encode file handler for inotify: %d\n", ret);
> > >   		return;
> > > -- 
> > > 2.1.0
> > > 
> > > 
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR