Re: [PATCH] b43: Fix use true/false for bool type

From: Joe Perches
Date: Tue Oct 29 2019 - 04:30:47 EST


On Tue, 2019-10-29 at 09:24 +0100, Simon Horman wrote:
> I wonder why bools rather than a bitmask was chosen
> for this field, it seems rather space intensive in its current form.

4 bools is not intensive.

> > diff --git a/drivers/net/wireless/broadcom/b43/main.c b/drivers/net/wireless/broadcom/b43/main.c
[]
> > @@ -3600,7 +3600,7 @@ static void b43_tx_work(struct work_struct *work)
[]
> > - wl->tx_queue_stopped[queue_num] = 1;
> > + wl->tx_queue_stopped[queue_num] = true;