Re: [PATCH v2 01/11] ASoC: dt-bindings: add dt bindings for WCD9340/WCD9341 audio codec

[Srinivas Kandagatla]

Thanks Rob for the review.

On 25/10/2019 21:43, Rob Herring wrote:
> On Fri, Oct 18, 2019 at 01:18:39AM +0100, Srinivas Kandagatla wrote:
> > This patch adds bindings for wcd9340/wcd9341 audio codec which can
> > support both SLIMbus and I2S/I2C interface.
> >
> > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> > ---
> >   .../bindings/sound/qcom,wcd934x.yaml          | 169 ++++++++++++++++++
> >   1 file changed, 169 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml
> > new file mode 100644
> > index 000000000000..299d6b96c339
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml
> > @@ -0,0 +1,169 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/sound/qcom,wcd934x.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Bindings for Qualcomm WCD9340/WCD9341 Audio Codec
> > +
> > +maintainers:
> > +  - Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> > +
> > +description: |
> > +  Qualcomm WCD9340/WCD9341 Codec is a standalone Hi-Fi audio codec IC.
> > +  It has in-built Soundwire controller, pin controller, interrupt mux and
> > +  supports both I2S/I2C and SLIMbus audio interfaces.
> > +
> > +properties:
> > +  compatible:
> > +    const: slim217,250
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  reset-gpios:
> > +    description: GPIO spec for reset line to use
> > +    maxItems: 1
> > +
> > +  slim-ifc-dev:
> > +    description: SLIMBus Interface device phandle
>
> phandle or...
Its Phandle.

something like this is okay?

slim-ifc-dev:
  $ref: '/schemas/types.yaml#/definitions/phandle-array'
  description: SLIMBus Interface device phandle



> > +    maxItems: 1
>
> array?
>
> Needs a type if a phandle.
>
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  clock-names:
> > +    const: extclk
> > +
> > +  vdd-buck-supply:
> > +    description: A reference to the 1.8V buck supply
> > +
> > +  vdd-buck-sido-supply:
> > +    description: A reference to the 1.8V SIDO buck supply
> > +
> > +  vdd-rx-supply:
> > +    description: A reference to the 1.8V rx supply
> > +
> > +  vdd-tx-supply:
> > +    description: A reference to the 1.8V tx supply
> > +
> > +  vdd-vbat-supply:
> > +    description: A reference to the vbat supply
> > +
> > +  vdd-io-supply:
> > +    description: A reference to the 1.8V I/O supply
> > +
> > +  vdd-micbias-supply:
> > +    description: A reference to the micbias supply
> > +
> > +  qcom,micbias1-millivolt:
>
> The standard unit is '-microvolt'
>
> > +    description: Voltage betwee 1800mv-2850mv for micbias1 output
>
> typo...
Yep, will fix this and also move to standard unit microvolt

> Sounds like constraints.
>
> > +    allOf:
> > +      - $ref: /schemas/types.yaml#/definitions/uint32
>
> With standard units, you can drop the type.
>
> > +
> > +  qcom,micbias2-millivolt:
> > +    description: Voltage betwee 1800mv-2850mv for micbias2 output
> > +    allOf:
> > +      - $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > +  qcom,micbias3-millivolt:
> > +    description: Voltage betwee 1800mv-2850mv for micbias3 output
> > +    allOf:
> > +      - $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > +  qcom,micbias4-millivolt:
> > +    description: Voltage betwee 1800mv-2850mv for micbias4 output
> > +    allOf:
> > +      - $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > +  clock-output-names:
> > +    const: mclk
> > +
> > +  clock-frequency:
> > +    description: Clock frequency of output clk in Hz
> > +
> > +  interrupt-controller: true
> > +
> > +  '#interrupt-cells':
> > +    const: 1
> > +
> > +  '#clock-cells':
> > +    const: 0
> > +
> > +  '#sound-dai-cells':
> > +    const: 1
> > +
> > +  "#address-cells":
> > +    const: 1
> > +
> > +  "#size-cells":
> > +    const: 1
> > +
> > +patternProperties:
> > +  "^.*@[0-9a-f]+$":
> > +    type: object
> > +    description: |
> > +      WCD934x subnode for each slave devices. Bindings of each subnodes
> > +      depends on the specific driver providing the functionality and
> > +      documented in there respective bindings.
>
> s/there/their/

will fix this in next version!

thanks,
srini