Re: [PATCH v2 1/4] perf: Allow using AUX data in perf samples

From: Alexander Shishkin
Date: Fri Oct 25 2019 - 08:21:18 EST


Peter Zijlstra <peterz@xxxxxxxxxxxxx> writes:

>> @@ -6511,6 +6629,13 @@ void perf_output_sample(struct perf_output_handle *handle,
>> if (sample_type & PERF_SAMPLE_PHYS_ADDR)
>> perf_output_put(handle, data->phys_addr);
>>
>> + if (sample_type & PERF_SAMPLE_AUX) {
>> + perf_output_put(handle, data->aux_size);
>> +
>> + if (data->aux_size)
>> + perf_aux_sample_output(event, handle, data);
>> + }
>> +
>> if (!event->attr.watermark) {
>> int wakeup_events = event->attr.wakeup_events;
>
>
> So, afaict, you can simply remove the line in perf_sample_data_init().

That's right, thanks for catching this.

Regards,
--
Alex