Re: [PATCH] perf annotate: ensure objdump argv is NULL terminated

From: Arnaldo Carvalho de Melo
Date: Tue Oct 15 2019 - 07:40:24 EST


Em Mon, Oct 14, 2019 at 05:34:18PM -0700, Ian Rogers escreveu:
> Provide null termination.

Since this hasn't been pushed upstream yet I folded it into the patch
where it should've been, to keep bisection.

Thanks,

- Arnaldo

> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
> ---
> tools/perf/util/annotate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
> index f7c620e0099b..a9089e64046d 100644
> --- a/tools/perf/util/annotate.c
> +++ b/tools/perf/util/annotate.c
> @@ -1921,6 +1921,7 @@ static int symbol__disassemble(struct symbol *sym, struct annotate_args *args)
> NULL, /* Will be the objdump command to run. */
> "--",
> NULL, /* Will be the symfs path. */
> + NULL,
> };
> struct child_process objdump_process;
> int err = dso__disassemble_filename(dso, symfs_filename, sizeof(symfs_filename));
> --
> 2.23.0.700.g56cf767bdb-goog

--

- Arnaldo