RE: [PATCH 4/6] PCI: mobiveil: Add workaround for unsupported request error
From: Xiaowei Bao
Date: Tue Oct 15 2019 - 03:46:56 EST
> -----Original Message-----
> From: Russell King - ARM Linux admin <linux@xxxxxxxxxxxxxxx>
> Sent: 2019年9月25日 0:50
> To: Xiaowei Bao <xiaowei.bao@xxxxxxx>
> Cc: Z.q. Hou <zhiqiang.hou@xxxxxxx>; bhelgaas@xxxxxxxxxx;
> robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx; shawnguo@xxxxxxxxxx; Leo Li
> <leoyang.li@xxxxxxx>; kishon@xxxxxx; lorenzo.pieralisi@xxxxxxx; M.h. Lian
> <minghuan.lian@xxxxxxx>; andrew.murray@xxxxxxx; Mingkai Hu
> <mingkai.hu@xxxxxxx>; linux-pci@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 4/6] PCI: mobiveil: Add workaround for unsupported
> request error
>
> On Mon, Sep 16, 2019 at 10:17:40AM +0800, Xiaowei Bao wrote:
> > Errata: unsupported request error on inbound posted write transaction,
> > PCIe controller reports advisory error instead of uncorrectable error
> > message to RC.
> >
> > Signed-off-by: Xiaowei Bao <xiaowei.bao@xxxxxxx>
> > ---
> > drivers/pci/controller/mobiveil/pcie-layerscape-gen4-ep.c | 13
> +++++++++++++
> > drivers/pci/controller/mobiveil/pcie-mobiveil.h | 4 ++++
> > 2 files changed, 17 insertions(+)
> >
> > diff --git a/drivers/pci/controller/mobiveil/pcie-layerscape-gen4-ep.c
> > b/drivers/pci/controller/mobiveil/pcie-layerscape-gen4-ep.c
> > index 7bfec51..5bc9ed7 100644
> > --- a/drivers/pci/controller/mobiveil/pcie-layerscape-gen4-ep.c
> > +++ b/drivers/pci/controller/mobiveil/pcie-layerscape-gen4-ep.c
> > @@ -49,6 +49,19 @@ static void ls_pcie_g4_ep_init(struct
> mobiveil_pcie_ep *ep)
> > struct mobiveil_pcie *mv_pci = to_mobiveil_pcie_from_ep(ep);
> > int win_idx;
> > u8 bar;
> > + u32 val;
> > +
> > + /*
> > + * Errata: unsupported request error on inbound posted write
> > + * transaction, PCIe controller reports advisory error instead
> > + * of uncorrectable error message to RC.
> > + * workaround: set the bit20(unsupported_request_Error_severity) with
> > + * value 1 in uncorrectable_Error_Severity_Register, make the
> > + * unsupported request error generate the fatal error.
> > + */
> > + val = csr_readl(mv_pci, CFG_UNCORRECTABLE_ERROR_SEVERITY);
> > + val |= 1 << UNSUPPORTED_REQUEST_ERROR_SHIFT;
>
> BIT(UNSUPPORTED_REQUEST_ERROR_SHIFT) ?
OK, thanks
Thanks
Xiaowei
>
> > + csr_writel(mv_pci, val, CFG_UNCORRECTABLE_ERROR_SEVERITY);
> >
> > ep->bar_num = PCIE_LX2_BAR_NUM;
> >
> > diff --git a/drivers/pci/controller/mobiveil/pcie-mobiveil.h
> > b/drivers/pci/controller/mobiveil/pcie-mobiveil.h
> > index 7308fa4..a40707e 100644
> > --- a/drivers/pci/controller/mobiveil/pcie-mobiveil.h
> > +++ b/drivers/pci/controller/mobiveil/pcie-mobiveil.h
> > @@ -123,6 +123,10 @@
> > #define GPEX_BAR_SIZE_UDW 0x4DC
> > #define GPEX_BAR_SELECT 0x4E0
> >
> > +#define CFG_UNCORRECTABLE_ERROR_SEVERITY 0x10c
> > +#define UNSUPPORTED_REQUEST_ERROR_SHIFT 20
> > +#define CFG_UNCORRECTABLE_ERROR_MASK 0x108
> > +
> > /* starting offset of INTX bits in status register */
> > #define PAB_INTX_START 5
> >
> > --
> > 2.9.5
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists
> > .infradead.org%2Fmailman%2Flistinfo%2Flinux-arm-kernel&data=02%
> 7C0
> >
> 1%7Cxiaowei.bao%40nxp.com%7C7dcebcdf565143413a7708d7410f34f5%7C
> 686ea1d
> >
> 3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637049405876399774&sd
> ata=%2Ff8
> >
> nQ70PbPpeR%2BlFdLm%2B%2FPZ9zl1HC%2BIYc1Ib%2BDbARGQ%3D&r
> eserved=0
> >
>
> --
> RMK's Patch system:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.
> armlinux.org.uk%2Fdeveloper%2Fpatches%2F&data=02%7C01%7Cxiao
> wei.bao%40nxp.com%7C7dcebcdf565143413a7708d7410f34f5%7C686ea1d3
> bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637049405876404764&sda
> ta=3rPA4kJYtQyGcHS4m%2B4mSpiJIYx9Ykzhaw73bV01Wks%3D&reserv
> ed=0
> FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps
> up According to speedtest.net: 11.9Mbps down 500kbps up