Re: [PATCH 1/2] acpi: Fail GED probe when not on hardware-reduced

From: Rafael J. Wysocki
Date: Mon Oct 14 2019 - 04:55:57 EST


On Fri, Oct 11, 2019 at 2:14 PM Samuel Ortiz <sameo@xxxxxxxxxxxxxxx> wrote:
>
> On Fri, Oct 11, 2019 at 12:38:49PM +0200, Rafael J. Wysocki wrote:
> > On Wed, Oct 9, 2019 at 3:04 PM Samuel Ortiz <sameo@xxxxxxxxxxxxxxx> wrote:
> > >
> > > The Generic Event Device (GED) is a hardware-reduced platform device.
> >
> > No, it is not AFAICS.
> It's a little confusing, I was not sure what's the common understanding
> and tried to be safe by not having non HW-reduced machines getting a
> new device that they've never seen so far.

I really don't expect firmware to expose GED for such machines (why
would it?), but if it does so, then why not to handle it?

> > The spec doesn't say that GED cannot be used on platforms that aren't
> > HW-reduced
> I agree.
>
> > and if evged.c is going to be built in unconditionally, the
> > kernel will be able to handle GED regardless.
> Ok, perfect then. Does that mean you're ok with the 2nd patch but are
> going to drop this one?

Sure, I will apply the second patch only.

Thanks!