Re: [PATCH] ath10k: Correct error check of dma_map_single()

From: Kalle Valo
Date: Fri Oct 11 2019 - 07:57:36 EST


Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> wrote:

> The return value of dma_map_single() should be checked for errors using
> dma_mapping_error(), rather than testing for NULL. Correct this.
>
> Fixes: 1807da49733e ("ath10k: wmi: add management tx by reference support over wmi")
> Cc: stable@xxxxxxxxxxxxxxx
> Reported-by: Niklas Cassel <niklas.cassel@xxxxxxxxxx>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>

Did this fix any real bug? Or is this just something found during code review?

--
https://patchwork.kernel.org/patch/11183923/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches