Re: [PATCH v9 3/5] mfd: ioc3: Add driver for SGI IOC3 chip

From: Thomas Bogendoerfer
Date: Fri Oct 11 2019 - 04:37:15 EST


On Thu, 10 Oct 2019 20:00:02 -0700
Jakub Kicinski <jakub.kicinski@xxxxxxxxxxxxx> wrote:

> On Thu, 10 Oct 2019 16:59:49 +0200, Thomas Bogendoerfer wrote:
> > dev = alloc_etherdev(sizeof(struct ioc3_private));
> > - if (!dev) {
> > - err = -ENOMEM;
> > - goto out_disable;
> > - }
> > -
> > - if (pci_using_dac)
> > - dev->features |= NETIF_F_HIGHDMA;
>
> Looks like the NETIF_F_HIGHDMA feature will not longer be set, is that
> okay?

yes, all platforms where ioc3 is usable are running 64bit kernels without
HIGHMEM.

Thomas.

--
SUSE Software Solutions Germany GmbH
HRB 247165 (AG München)
Geschäftsführer: Felix Imendörffer