Re: [PATCH] net: stmmac: fix disabling flexible PPS output

From: Jakub Kicinski
Date: Wed Oct 09 2019 - 19:10:28 EST


On Mon, 7 Oct 2019 17:43:05 +0200, Antonio Borneo wrote:
> Accordingly to Synopsys documentation [1] and [2], when bit PPSEN0
> in register MAC_PPS_CONTROL is set it selects the functionality
> command in the same register, otherwise selects the functionality
> control.
> Command functionality is required to either enable (command 0x2)
> and disable (command 0x5) the flexible PPS output, but the bit
> PPSEN0 is currently set only for enabling.
>
> Set the bit PPSEN0 to properly disable flexible PPS output.
>
> Tested on STM32MP15x, based on dwmac 4.10a.
>
> [1] DWC Ethernet QoS Databook 4.10a October 2014
> [2] DWC Ethernet QoS Databook 5.00a September 2017
>
> Signed-off-by: Antonio Borneo <antonio.borneo@xxxxxx>
> Fixes: 9a8a02c9d46d ("net: stmmac: Add Flexible PPS support")

Applied to net, queued for stable.