Re: [PATCH 0/2] block, bfq: make bfq disable iocost and present a double interface

From: Paolo Valente
Date: Wed Oct 09 2019 - 10:25:09 EST


Jens, Tejun,
can we proceed with this double-interface solution?

Thanks,
Paolo

> Il giorno 1 ott 2019, alle ore 21:33, Paolo Valente <paolo.valente@xxxxxxxxxx> ha scritto:
>
> Hi Jens,
>
> the first patch in this series is Tejun's patch for making BFQ disable
> io.cost. The second patch makes BFQ present both the bfq-prefixes
> parameters and non-prefixed parameters, as suggested by Tejun [1].
>
> In the first patch I've tried to use macros not to repeat code
> twice. checkpatch complains that these macros should be enclosed in
> parentheses. I don't see how to do it. I'm willing to switch to any
> better solution.
>
> Thanks,
> Paolo
>
> [1] https://lkml.org/lkml/2019/9/18/736
>
> Paolo Valente (1):
> block, bfq: present a double cgroups interface
>
> Tejun Heo (1):
> blkcg: Make bfq disable iocost when enabled
>
> Documentation/admin-guide/cgroup-v2.rst | 8 +-
> Documentation/block/bfq-iosched.rst | 40 ++--
> block/bfq-cgroup.c | 260 ++++++++++++------------
> block/bfq-iosched.c | 32 +++
> block/blk-iocost.c | 5 +-
> include/linux/blk-cgroup.h | 5 +
> kernel/cgroup/cgroup.c | 2 +
> 7 files changed, 201 insertions(+), 151 deletions(-)
>
> --
> 2.20.1