Re: [PATCH v2 2/6] rpmsg: glink: Fix use after free in open_ack TIMEOUT case

From: Chris Lew
Date: Tue Oct 08 2019 - 20:51:13 EST




On 10/4/2019 3:26 PM, Bjorn Andersson wrote:
From: Arun Kumar Neelakantam <aneela@xxxxxxxxxxxxxx>

Extra channel reference put when remote sending OPEN_ACK after timeout
causes use-after-free while handling next remote CLOSE command.

Remove extra reference put in timeout case to avoid use-after-free.

Fixes: b4f8e52b89f6 ("rpmsg: Introduce Qualcomm RPM glink driver")
Cc: stable@xxxxxxxxxxxxxxx
Tested-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
Signed-off-by: Arun Kumar Neelakantam <aneela@xxxxxxxxxxxxxx>
Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
---

Acked-By: Chris Lew <clew@xxxxxxxxxxxxxx>

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project