Re: [PATCH RFC net-next 0/2] drivers: net: virtio_net: Implement

From: Michael S. Tsirkin
Date: Mon Oct 07 2019 - 03:43:59 EST


On Sun, Oct 06, 2019 at 03:45:13PM -0300, jcfaracco@xxxxxxxxx wrote:
> From: Julio Faracco <jcfaracco@xxxxxxxxx>
>
> Driver virtio_net is not handling error events for TX provided by
> dev_watchdog. This event is reached when transmission queue is having
> problems to transmit packets. To enable it, driver should have
> .ndo_tx_timeout implemented. This serie has two commits:
>
> In the past, we implemented a function to recover driver state when this
> kind of event happens, but the structure was to complex for virtio_net
> that moment.

It's more that it was missing a bunch of locks.

> Alternativelly, this skeleton should be enough for now.
>
> For further details, see thread:
> https://lkml.org/lkml/2015/6/23/691
>
> Patch 1/2:
> Add statistic field for TX timeout events.
>
> Patch 2/2:
> Implement a skeleton function to debug TX timeout events.
>
> Julio Faracco (2):
> drivers: net: virtio_net: Add tx_timeout stats field
> drivers: net: virtio_net: Add tx_timeout function
>
> drivers/net/virtio_net.c | 33 ++++++++++++++++++++++++++++++++-
> 1 file changed, 32 insertions(+), 1 deletion(-)
>
> --
> 2.21.0