Re: [PATCH AUTOSEL 5.2 17/42] MIPS: lantiq: update the clock alias' for the mainline PCIe PHY driver

From: Sasha Levin
Date: Sat Oct 05 2019 - 19:01:13 EST


On Sun, Sep 29, 2019 at 07:39:49PM +0200, Hauke Mehrtens wrote:
On 9/29/19 7:32 PM, Sasha Levin wrote:
From: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>

[ Upstream commit ed90302be64a53d9031c8ce05428c358b16a5d96 ]

The mainline PCIe PHY driver has it's own devicetree node. Update the
clock alias so the mainline driver finds the clocks.

The first PCIe PHY is located at 0x1f106800 and exists on VRX200, ARX300
and GRX390.
The second PCIe PHY is located at 0x1f700400 and exists on ARX300 and
GRX390.
The third PCIe PHY is located at 0x1f106a00 and exists onl on GRX390.
Lantiq's board support package (called "UGW") names these registers
"PDI".

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
Signed-off-by: Paul Burton <paul.burton@xxxxxxxx>
Cc: linux-mips@xxxxxxxxxxxxxxx
Cc: devicetree@xxxxxxxxxxxxxxx
Cc: john@xxxxxxxxxxx
Cc: kishon@xxxxxx
Cc: ralf@xxxxxxxxxxxxxx
Cc: robh+dt@xxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx
Cc: hauke@xxxxxxxxxx
Cc: mark.rutland@xxxxxxx
Cc: ms@xxxxxxxxxx
Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
---
arch/mips/lantiq/xway/sysctrl.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)

Hi Sasha,

This change only makes sense with the new upstream PCIe phy driver which
was added to kernel 5.4 [0], older kernel versions do not have this PCIe
PHY driver. I would not backport these changes to older kernel versions.

I'll drop it, thank you!

--
Thanks,
Sasha