Re: [PATCH 4.19 090/211] media: mceusb: fix (eliminate) TX IR signal length limit

From: Sasha Levin
Date: Fri Oct 04 2019 - 09:47:35 EST


On Fri, Oct 04, 2019 at 12:12:15PM +0200, Pavel Machek wrote:
On Thu 2019-10-03 17:52:36, Greg Kroah-Hartman wrote:
From: A Sun <as1033x@xxxxxxxxxxx>

Other changes:

The driver's write to USB device architecture change (async to sync I/O)
is significant so we bump DRIVER_VERSION to "1.95" (from "1.94").

---
drivers/media/rc/mceusb.c | 334 ++++++++++++++++++++++----------------
1 file changed, 196 insertions(+), 138 deletions(-)

This is not a bugfix, this is rewrite that happens to remove a
limitation, and it is way over the 100 line limit. What is going on
here? Why is it even considered for stable?

It's on the bigger side, sure, but it's contained inside a driver and
seems to fix an actual issue.

--
Thanks,
Sasha