Re: [PATCH v5 2/6] arm64: vdso32: Detect binutils support for dmb ishld

From: Nick Desaulniers
Date: Thu Oct 03 2019 - 17:51:32 EST


On Thu, Oct 3, 2019 at 1:59 PM Will Deacon <will@xxxxxxxxxx> wrote:
>
> On Thu, Oct 03, 2019 at 01:56:39PM -0700, Nick Desaulniers wrote:
> > On Thu, Oct 3, 2019 at 1:49 PM Will Deacon <will@xxxxxxxxxx> wrote:
> > >
> > > On Thu, Oct 03, 2019 at 01:18:16PM -0700, Nick Desaulniers wrote:
> > > > On Thu, Oct 3, 2019 at 10:48 AM Vincenzo Frascino
> > > > <vincenzo.frascino@xxxxxxx> wrote:
> > > > >
> > > > > Older versions of binutils that do not support certain types of memory
> > > > > barriers can cause build failure of the vdso32 library.
> > > >
> > > > Do you know specific version numbers of binutils that are affected?
> > > > May be helpful to have in the commit message just for future
> > > > travelers.
> > >
> > > A quick bit of archaeology suggests e797f7e0b2be added this back in 2012,
> > > which seems to correlate with the 2.24 release.
> >
> > Cool, thanks for digging. Vincenzo, can we please add that to the
> > commit message?
>
> If this is the only change, then I can add it when I apply -- no need to
> respin just for this! (although I'm also writing this to remind myself :)

Yep that's cool with me. Feel free to add my Acked by tag to the
series as well. Thanks for pursuing this Vincenzo.
--
Thanks,
~Nick Desaulniers