Re: [PATCH 13/15] mm: Add a huge page fault handler for files

From: Kirill A. Shutemov
Date: Tue Oct 01 2019 - 06:42:24 EST


On Tue, Sep 24, 2019 at 05:52:12PM -0700, Matthew Wilcox wrote:
> From: William Kucharski <william.kucharski@xxxxxxxxxx>
>
> Add filemap_huge_fault() to attempt to satisfy page
> faults on memory-mapped read-only text pages using THP when possible.
>
> Signed-off-by: William Kucharski <william.kucharski@xxxxxxxxxx>
> [rebased on top of mm prep patches -- Matthew]
> Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>

As we discuss before, I think it's wrong direction to separate ->fault()
from ->huge_fault(). If ->fault() would return a huge page alloc_set_pte()
will do The Right Thingâ.

--
Kirill A. Shutemov