Re: [PATCH 09/13] arm64: dts: rockchip: document explicit px30 cru dependencies

From: Rob Herring
Date: Mon Sep 30 2019 - 18:58:15 EST


On Tue, 17 Sep 2019 10:26:55 +0200, Heiko Stuebner wrote:
> The px30 contains 2 separate clock controllers the regular cru creating
> most clocks as well as the pmucru managing the GPLL and some other clocks.
>
> The gpll of course also is needed by the cru, so while we normally do rely
> on clock names to associate clocks getting probed later on (for example
> xin32k coming from an i2c device in most cases) it is safer to declare the
> explicit dependency between the two crus. This makes sure that for example
> the clock-framework probes them in the correct order from the start.
>
> The assigned-clocks properties were simply working by chance in the past
> so split them accordingly to the 2 crus to honor the loading direction.
>
> Signed-off-by: Heiko Stuebner <heiko@xxxxxxxxx>
> ---
> .../bindings/clock/rockchip,px30-cru.txt | 5 ++++
> arch/arm64/boot/dts/rockchip/px30.dtsi | 25 +++++++++++--------
> 2 files changed, 20 insertions(+), 10 deletions(-)
>

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>