Re: [PATCH 2/3] dt-bindings: serial: document LiteUART bindings

[Rob Herring]

On Mon, Sep 30, 2019 at 8:04 AM Mateusz Holenko <mholenko@xxxxxxxxxxxx> wrote:
>
> From: Filip Kokosinski <fkokosinski@xxxxxxxxxxxxxxxxxxxxxxxx>
>
> Add documentation for LiteUART devicetree bindings.
>
> Signed-off-by: Filip Kokosinski <fkokosinski@xxxxxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Mateusz Holenko <mholenko@xxxxxxxxxxxx>
> ---
>  .../devicetree/bindings/serial/litex,liteuart.txt    | 12 ++++++++++++
>  MAINTAINERS                                          |  6 ++++++
>  2 files changed, 18 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/serial/litex,liteuart.txt

Please make this a schema. See
Documentation/devicetree/writing-schema.rst (or .md before 5.4).

>
> diff --git a/Documentation/devicetree/bindings/serial/litex,liteuart.txt b/Documentation/devicetree/bindings/serial/litex,liteuart.txt
> new file mode 100644
> index 000000000..13c71a0c9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/serial/litex,liteuart.txt
> @@ -0,0 +1,12 @@
> +LiteUART serial controller
> +
> +Required properties:
> +- compatible: should be "litex,liteuart"

Only 1 version?

> +- reg: base address and length of the register set for this device

Is there really no interrupt line? That should be added if there's h/w
support even if the driver doesn't yet support it.

> +
> +Example:
> +
> +uart0: serial@f0001000 {

Wrong unit address. Should be "@e0001800".


> +       compatible = "litex,liteuart";
> +       reg = <0xe0001800 0x100>;
> +};
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b2326dece..65a6cf296 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -9462,6 +9462,12 @@ F:       Documentation/misc-devices/lis3lv02d.rst
>  F:     drivers/misc/lis3lv02d/
>  F:     drivers/platform/x86/hp_accel.c
>
> +LITEX PLATFORM
> +M:     Karol Gugala <kgugala@xxxxxxxxxxxx>
> +M:     Mateusz Holenko <mholenko@xxxxxxxxxxxx>
> +S:     Maintained
> +F:     Documentation/devicetree/bindings/serial/litex,liteuart.txt
> +
>  LIVE PATCHING
>  M:     Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
>  M:     Jiri Kosina <jikos@xxxxxxxxxx>
> --
> 2.23.0
>