Re: [PATCH 4.19 53/63] f2fs: fix to do sanity check on segment bitmap of LFS curseg

[Sasha Levin]

On Mon, Sep 30, 2019 at 03:36:16PM +0800, Chao Yu wrote:
> Hello,
>
> On 2019/9/30 15:21, Pavel Machek wrote:
> > Hi!
> >
> >
> > > +		for (blkofs += 1; blkofs < sbi->blocks_per_seg; blkofs++) {
> > > +			if (!f2fs_test_bit(blkofs, se->cur_valid_map))
> > > +				continue;
> > > +out:
> > > +			f2fs_msg(sbi->sb, KERN_ERR,
> > > +				"Current segment's next free block offset is "
> > > +				"inconsistent with bitmap, logtype:%u, "
> > > +				"segno:%u, type:%u, next_blkoff:%u, blkofs:%u",
> > > +				i, curseg->segno, curseg->alloc_type,
> > > +				curseg->next_blkoff, blkofs);
> > > +			return -EINVAL;
> > > +		}
> >
> > So this is detecting filesystem corruption, right? Should it be
> > -EUCLEAN?
>
> Was fixed in another commit 10f966bbf521 ("f2fs: use generic
> EFSBADCRC/EFSCORRUPTED"). :)

I've queued up a backport of this for 5.2, 4.19, and 4.14, thanks!.

--
Thanks,
Sasha