Re: [PATCH] xfs: Fix tail rounding in xfs_alloc_file_space()

From: Christoph Hellwig
Date: Mon Sep 30 2019 - 03:48:56 EST


On Thu, Sep 26, 2019 at 04:22:38PM +0200, Max Reitz wrote:
> To ensure that all blocks touched by the range [offset, offset + count)
> are allocated, we need to calculate the block count from the difference
> of the range end (rounded up) and the range start (rounded down).
>
> Before this patch, we just round up the byte count, which may lead to
> unaligned ranges not being fully allocated:

Looks fine:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>