Re: [Cocci] [RFC PATCH] scripts: Fix coccicheck failed

From: Julia Lawall
Date: Sun Sep 29 2019 - 14:05:37 EST




On Sun, 29 Sep 2019, Markus Elfring wrote:

> > Maybe the problem would be solved by putting virtual report at the top of the rule.
>
> I assume that support for the operation mode âpatchâ can eventually be considered.
>

Coccicheck requires that all rules support the report mode.

julia

>
> > But it might still fail because nothing can happen without a value
> > for the virtual metavariable ns.
>
> I imagine that the safe handling of this command line input parameter
> will trigger further software development concerns.
>
>
> > Should the coccinelle directory be only for things that work with make coccicheck,
>
> I hope not.
>
> But it seems that a filter command expressed such a restriction so far.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/coccicheck?id=02dc96ef6c25f990452c114c59d75c368a1f4c8f#n257
>
> Is this place an update candidate now?
>
>
> > or for all Coccinelle scripts?
>
> I would prefer file storage selections in this direction.
> How do you think about to improve the software taxonomy accordingly?
>
> Regards,
> Markus
>