Re: [PATCH v5 16/16] mm/userfaultfd: Honor FAULT_FLAG_KILLABLE in fault path

From: Peter Xu
Date: Sun Sep 29 2019 - 05:19:39 EST


On Thu, Sep 26, 2019 at 05:39:04PM +0800, Peter Xu wrote:
> @@ -490,8 +512,7 @@ vm_fault_t handle_userfault(struct vm_fault *vmf, unsigned long reason)
> up_read(&mm->mmap_sem);
>
> if (likely(must_wait && !READ_ONCE(ctx->released) &&
> - (return_to_userland ? !signal_pending(current) :
> - !fatal_signal_pending(current)))) {
> + userfaultfd_signal_pending(vmf->flags))) {

Sorry, here it should be "!userfaultfd_signal_pending(vmf->flags)".

--
Peter Xu