Re: [PATCH v22 02/24] x86/cpufeatures: x86/msr: Intel SGX Launch Control hardware bits

From: Jarkko Sakkinen
Date: Fri Sep 27 2019 - 12:12:06 EST


On Wed, Sep 25, 2019 at 10:18:24AM -0700, Sean Christopherson wrote:
> > I wouldn't be too surprised if this happened. BIOS is very inventive.
>
> Given the number of steps BIOS needs to take to enable SGX, that'd be one
> "inventive" BIOS. :-)
>
> Anyways, adding logic to opportunistically set FEATURE_CONTROL during boot
> should be trivial. I'll prep a patch and send it separately from the SGX
> series, moving the existing KVM code would be a good change irrespective
> of SGX.

Also, based on Borislav's remarks, the commit message should be more
clear about launch control (separately describe the driver and KVM
use). I can rework that.

/Jarkko