Re: [RESEND][PATCH v8 5/5] kselftests: Add dma-heap test

From: Brian Starkey
Date: Fri Sep 27 2019 - 05:22:21 EST


Hi John,

On Thu, Sep 26, 2019 at 02:36:33PM -0700, John Stultz wrote:
> On Mon, Sep 23, 2019 at 3:12 PM Brian Starkey <Brian.Starkey@xxxxxxx> wrote:
> >
> > I didn't see any response about using the test harness. Did you decide
> > against it?
>
> Hey! Spent a little time looking at this bit and just wanted to reply
> to this point. So first, apologies, I think I missed the suggestion
> earlier. That said, now that I've looked a little bit at the test
> harness, and at least at this point it feels like it makes it harder
> to reason with than standard c code. Maybe I need to spend a bit more
> time on it, but I'm a little hesitant to swap over just yet.
>
> I'm not particularly passionate on this point, but are you? Or was
> this just a recommendation to check it out and consider it?

No particular strong feelings. I was just poking around the kernel
docs for testing and the only info there is about the test harness, so
wanted to check if you'd seen/considered it.

A quick grep of tools/testing shows that it's obviously not that
popular... so if you don't fancy it I won't complain.

Thanks,
-Brian

>
> thanks
> -john