Re: [PATCH] xhci: Increase STS_SAVE timeout in xhci_suspend()

From: Mathias Nyman
Date: Fri Sep 27 2019 - 02:28:34 EST


On 26.9.2019 20.57, Kai-Heng Feng wrote:
After commit f7fac17ca925 ("xhci: Convert xhci_handshake() to use
readl_poll_timeout_atomic()"), ASMedia xHCI may fail to suspend.

Although the algorithms are essentially the same, the old max timeout is
(usec + usec * time of doing readl()), and the new max timeout is just
usec, which is much less than the old one.

Increase the timeout to make ASMedia xHCI able to suspend again.

BugLink: https://bugs.launchpad.net/bugs/1844021
Fixes: f7fac17ca925 ("xhci: Convert xhci_handshake() to use readl_poll_timeout_atomic()")
Signed-off-by: Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx>
---

Thanks, adding to queue with stable tag for v5.2+ kernels

-Mathias