Re: [PATCH] clocksource: mediatek: fix error handling

From: Daniel Lezcano
Date: Wed Sep 25 2019 - 12:42:42 EST


On 19/09/2019 21:13, Fabien Parent wrote:
> When timer_of_init fails, it cleans up after itself by undoing
> everything it did during the initialization function.
>
> mtk_syst_init and mtk_gpt_init both call timer_of_cleanup if
> timer_of_init fails. timer_of_cleanup try to release the resource taken.
> Since these resources have already been cleaned up by timer_of_init,
> we end up getting a few warnings printed:

[ ... ]

> This commit remove the calls to timer_of_cleanup when timer_of_init
> fails since it is unnecessary and actually cause warnings to be printed.
>
> Signed-off-by: Fabien Parent <fparent@xxxxxxxxxxxx>

Applied, thanks for the fix!

In the future add the 'Fixes' tag please.

-- Daniel

--
<http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog